New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samtools: 1.5.0 -> 1.6.0 #29963
samtools: 1.5.0 -> 1.6.0 #29963
Conversation
Using binaries from PATH is the reasonable thing to do for upstream projects, so I don't think that we should patch in absolute paths. Just add the necessary programs to |
Thanks a lot @orivej. I didn't do that because I didn't know which was better buildInputs vs nativeBuildInputs. I will update the commits as soon as possible |
c4aa48e
to
9f21e1e
Compare
@orivej Fixed. Don't hesitate to ask for more changes |
Why didn't you add |
9f21e1e
to
bebccf1
Compare
@orivej, thanks a lot for your support and help |
Please review my changes. samtools and bcftools install some python and perl scripts. We do not even depend on python, and I have not checked that perl scripts have all the necessary dependencies to run. This can be left as is until someone needs them. |
1023c8a
to
d73bd7f
Compare
That's perfect but I think that htslib has to be propagated to samtools and bcftools for using bgzip and tabix |
Do you mean that users of samtools and bcftools also need bgzip and tabix in their PATH? |
I think so because in other distros the htslib dependency is visible from PATH by default. |
Other distros have no other way. From a quick glance it does not seem that samtools need htslib binaries. (Even if they did, the proper solution is a program wrapper that adds htslib to the PATH of the wrapped program, not a propagation of htslib.) |
Motivation for this change
htslib, samtools and bcftools
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)