Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared-mime-info: 1.8 -> 1.9 #29965

Merged
merged 1 commit into from Sep 30, 2017
Merged

shared-mime-info: 1.8 -> 1.9 #29965

merged 1 commit into from Sep 30, 2017

Conversation

mimame
Copy link
Member

@mimame mimame commented Sep 30, 2017

Motivation for this change

Update shared-mime-info to last version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Sep 30, 2017

This rebuilds 393 packages including the whole KDE and should probably go to staging.

jtojnar
jtojnar approved these changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine, looks good to me.

Changelog

@mimame mimame changed the base branch from master to staging September 30, 2017 18:26
@mimame
Copy link
Member Author

mimame commented Sep 30, 2017

Thanks a lot by those comments. I've changed the targeted branch to staging

@orivej orivej merged commit 62e6137 into NixOS:staging Sep 30, 2017
@orivej
Copy link
Contributor

orivej commented Sep 30, 2017

Thank you! Merged to staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mimame @orivej @jtojnar