New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom pool executor was missing priority and stacksize options #2921
Conversation
NB. I do not like the name customized_pool_executor and I think we should rename it early - before it starts to get used in examples and by users in the wider community Instead of customized_pool_executor I suggest
|
|
I like option 2.
Am 01.10.2017 10:49 vorm. schrieb "John Biddiscombe" <
notifications@github.com>:
… NB. I do not like the name customized_pool_executor and I think we should
rename it early - before it starts to get used in examples and by users in
the wider community
Instead of customized_pool_executor I suggest
1. custom_pool_executor (better English in my view)
2. pool_executor (since this is what it is, if existing classes use
this name, we should adjust them accordingly)
3. please suggest something.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2921 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADRly9vC1FT641SaIM_i3SJ_C6iUNIsks5sn1IXgaJpZM4Pp0ow>
.
|
ok. I will merge this commit (once approved) and then do a new one with the new name of pool_executorin the next day or two. |
Let's change the name right away. If it's a matter of a day or two - no problem. |
OK. executor renamed. I've got several other PR's on the way that depend on this, so I'm keen to get this merged ASAP. (= before tutorial!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Let's merge this as soon as the tests have cycled. |
hmm. The appveyor test failed for this, but I cannot find anything wrong. |
For some reason, hello_world prints:
(which is clearly wrong) and hangs afterwards. I'm not sure if this is caused by your changes, though. |
The problem reported in #2914 can actually be resolved by using a custom pool executor on the "default" pool instead of a default executor, for the tasks that do not go to the original custom pool.
Doing this reveald that the custom pool executor was missing the correct logic to handle stacksize and priority options that we need.