gucharmap: 3.18.2 -> 10.0.1 #29885
gucharmap: 3.18.2 -> 10.0.1 #29885
Conversation
| @@ -1,6 +1,7 @@ | |||
| { stdenv, intltool, fetchurl, pkgconfig, gtk3 | |||
| , glib, desktop_file_utils, bash, appdata-tools | |||
| , makeWrapper, gnome3, file, itstool, libxml2 }: | |||
| , wrapGAppsHook, gnome3, file, itstool, libxml2 | |||
There was a problem hiding this comment.
file is no longer used. Otherwise, it looks good to me.
- Gucharmap no longer follow the GNOME major versioning. - Gucharmap no longer includes Unicode data. Instead the data should be downloaded from unicode.org.
| @@ -1,10 +1,10 @@ | |||
| # Autogenerated by maintainers/scripts/gnome.sh update | |||
There was a problem hiding this comment.
No.
It is still generated by ./maintainers/scripts/gnome.sh update gucharmap.
Having gucharmap in NO_GNOME_MAJOR means that this package is not updated with the rest of GNOME by calling ./maintainers/scripts/gnome.sh update-all.
| gnome3.yelp_tools libxml2 desktop_file_utils | ||
| gnome3.gsettings_desktop_schemas ]; | ||
|
|
||
| unicode-data = callPackage ./unicode-data.nix {}; |
There was a problem hiding this comment.
This package seems useful outside gucharmap. For example, https://github.com/NixOS/nixpkgs/blob/26033a43/pkgs/tools/misc/unicode/default.nix could use it. However, I don't mind if it remains private for now.
There was a problem hiding this comment.
Yea.
However, I'm not sure which files it should contain (different apps may require different ucd files), and should it be zipped or not.
For example, gucharmap requires Unihan.zip to be zipped, but the contents of UCD.zip (Blocks.txt, UnicodeData.txt, ...) should be not.
There was a problem hiding this comment.
Arch package might be used as an inspiration: https://www.archlinux.org/packages/extra/any/unicode-character-database/.
|
Thank you for the clarifications. |
Motivation for this change
Update to the latest version.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)