Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdf5: remove references to gcc #29892

Closed
wants to merge 1 commit into from
Closed

hdf5: remove references to gcc #29892

wants to merge 1 commit into from

Conversation

shajra
Copy link
Contributor

@shajra shajra commented Sep 28, 2017

The build provides as text a summary of the build, including the
absolute path of the compiler used for compilation. Unfortunately, this
pulls in gcc as a transitive closure.

So this change just calls remove-references-to as a postInstall step for
the one gcc dependency.

See #29889 for details.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@shajra
hdf5: remove references to gcc
56a2983 
The build provides as text a summary of the build, including the
absolute path of the compiler used for compilation.  Unfortunately, this
pulls in gcc as a transitive closure.

So this change just calls remove-references-to as a postInstall step for
the one gcc dependency.

See NixOS#29889 for details.
@FRidh FRidh self-assigned this Sep 28, 2017
@joachifm
Copy link
Contributor

Targeting stdenv.cc seems like a more general approach. Does that work?

@orivej
Copy link
Contributor

orivej commented Sep 28, 2017 •
edited

@shajra This looks good, but please move removeReferencesTo into nativeBuildInputs and adhere to the common formatting style here:

postInstall = ''
  …code…
'';

@FRidh
Copy link
Member

FRidh commented Sep 28, 2017

Thanks. I've pushed 82667fe to master and 3b83be9 to 17.09.

@FRidh FRidh closed this Sep 28, 2017
@FRidh
Copy link
Member

FRidh commented Sep 28, 2017

...and now I notice I forgot to remove the gcc from the parameters sigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shajra @joachifm @orivej @FRidh