unicode: init at 2.5 #29891
Merged
unicode: init at 2.5 #29891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woffs
commented
Sep 28, 2017
| @@ -19224,6 +19224,8 @@ with pkgs; | |||
|
|
|||
| utf8proc = callPackage ../development/libraries/utf8proc { }; | |||
|
|
|||
| unicode-paracode = callPackage ../tools/misc/unicode { }; | |||
There was a problem hiding this comment.
I have used "unicode-paracode" here because with "unicode" I get
error: value is a set while a Boolean was expected
There was a problem hiding this comment.
it is used as argument in different locations like ncurses.
vyp
reviewed
Sep 28, 2017
pkgs/tools/misc/unicode/default.nix
Outdated
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "display unicode character properties"; |
woffs
force-pushed
the
unicode-paracode
branch
from
e514996
to
be12099
Compare
|
Thanks! |
xzfc
reviewed
Sep 30, 2017
| }; | ||
|
|
||
| ucdtxt = fetchurl { | ||
| url = http://www.unicode.org/Public/11.0.0/ucd/UnicodeData-11.0.0d1.txt; |
There was a problem hiding this comment.
I think it is better not to depend on not-yet-released Unicode data. I guess this file will be renamed UnicodeData.txt in the future, and this URL will break.
Related: there was a proposal at #29885 to move Unicode data to the separate package that other packages may depend on.
There was a problem hiding this comment.
You are right, I'll change that to the final 10.0.0 version.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
a great tool to explore unicode from the command line
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)