Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: fix docker_17_06 build #29888

Merged
merged 1 commit into from Sep 28, 2017
Merged

docker: fix docker_17_06 build #29888

merged 1 commit into from Sep 28, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 28, 2017 •
edited

Motivation for this change

https://github.com/NixOS/nixpkgs/pull/29843/files#r141527044

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej mentioned this pull request Sep 28, 2017
Merged
8 tasks
@globin globin merged commit f1ffca9 into NixOS:master Sep 28, 2017
@orivej orivej deleted the docker branch September 28, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orivej @globin