mongodb-tools: 3.0.12 -> 3.5.13 #29884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
changed the title
Mic92
reviewed
Sep 28, 2017
| buildPhase = '' | ||
| runHook preBuild | ||
| ${stdenv.lib.concatMapStrings (t: '' | ||
| go build -o "$bin/bin/${t}" -tags ssl -ldflags "-s -w" $goPackagePath/${t}/main |
There was a problem hiding this comment.
Go binaries where not stripped correctly.
There was a problem hiding this comment.
AFAIK Go packages do not refer to the Go compiler even with symbols and debug info. I have just built this package without -ldflags "-s -w".
There was a problem hiding this comment.
It definitely was referring to go before that commit. I saw it with strings. I don't where this was coming from. Nevertheless stripping binaries does not hurt as it results in smaller binaries.
|
Notice that we have a naming convention for package upgrades like that: |
globin
pushed a commit
that referenced
this pull request
Sep 28, 2017
* Upgrade mongodb-tools to 3.5.13 with ssl * mongodb-tools: fix go references (cherry picked from commit b46b046)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Need to connect to newer mongodb databases with SSL
I could use a little help with this upgrade as I am new to NixOS. Despite the build output saying all of the tools were compiled with SSL they behave as if they were compiled without ssl (--ssl option is not there).
Also the build somehow contains a reference to go, so I added allowGoReference but I know that is not the correct solution.
Thanks in advance for any help.