Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmake hook: force copy of binary fixes #29589 #29893

Closed
wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Sep 28, 2017

Motivation for this change

When running nix-shell several times in the same folder with a qt program (such as wireshark),
qmake's hook can generate the error "Can't create nix_qt5/bin/qmake:
file already exists"
Following up of #29665

Things done

force copy of the binary

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

When running nix-shell several times in the same folder with a qt program (such as wireshark),
qmake's hook can generate the error "Can't create __nix_qt5__/bin/qmake:
file already exists"
@vyp
Copy link
Member

vyp commented Sep 28, 2017

cc @ttuegel

@Mic92 Mic92 requested a review from ttuegel September 29, 2017 07:35
@ttuegel
Copy link
Member

ttuegel commented Nov 15, 2017

This is obsolete now because there are no copies to force.

@ttuegel ttuegel closed this Nov 15, 2017
@teto teto deleted the qmake_fix branch April 11, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants