-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
sqldeveloper: 4.1.1 -> 17.2.0 #29882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See the use of |
What am I supposed to look for? |
When we are not allowed to redistribute files or download them automatically, we use |
Yes thats also used in sqldeveloper What I meant to ask was, wether we could point the user to the direct download link in the message (isntead of the one listing the download options) |
you can create a message for users like this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/oracle-instantclient/default.nix#L12 |
Yes but is it allowed to point directly to the file in that message? I'd guess probably not |
@Eisfreak7 what do you mean by pointing directly to the file? The website requires authentication so user interaction is required AFAIK. |
Oh I assumed that you just need to login to see the link. But you're right, a simple curl without being logged in doesn't work. Then maybe I'll just write a more specific message explaining what to do and which file to choose. |
I added a detailed message explaining the process and updated to the newest version. This should be ready to merge now. |
Ok. I have no account there, but the code looks reasonable. |
Motivation for this change
When I installed sqldeveloper, I noticed that it is very much out of date.
What I'm unsure about: The website we point to for the manual download doesn't directly allow to download older versions. It is possible to manually replace the version of the file in the download link they give you though. Does anybody have experience with this? Would it be allowed to give a direkt download link, thereby probably bypassing the necessity to accept the license first? How else could this be solved?
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)