Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqldeveloper: 4.1.1 -> 17.2.0 #29882

Merged
merged 4 commits into from Oct 15, 2017
Merged

sqldeveloper: 4.1.1 -> 17.2.0 #29882

merged 4 commits into from Oct 15, 2017

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 27, 2017 •
edited

Motivation for this change

When I installed sqldeveloper, I noticed that it is very much out of date.

What I'm unsure about: The website we point to for the manual download doesn't directly allow to download older versions. It is possible to manually replace the version of the file in the download link they give you though. Does anybody have experience with this? Would it be allowed to give a direkt download link, thereby probably bypassing the necessity to accept the license first? How else could this be solved?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Oct 1, 2017

See the use of requireFile in nixpkgs.

@timokau
Copy link
Member Author

timokau commented Oct 3, 2017

What am I supposed to look for?

@orivej
Copy link
Contributor

orivej commented Oct 3, 2017

When we are not allowed to redistribute files or download them automatically, we use requireFile to ask the user to download the file from the original source.

@timokau
Copy link
Member Author

timokau commented Oct 4, 2017

Yes thats also used in sqldeveloper

What I meant to ask was, wether we could point the user to the direct download link in the message (isntead of the one listing the download options)

@Mic92
Copy link
Member

Mic92 commented Oct 7, 2017

you can create a message for users like this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/oracle-instantclient/default.nix#L12

@timokau
Copy link
Member Author

timokau commented Oct 9, 2017

Yes but is it allowed to point directly to the file in that message? I'd guess probably not

@Mic92
Copy link
Member

Mic92 commented Oct 9, 2017

@Eisfreak7 what do you mean by pointing directly to the file? The website requires authentication so user interaction is required AFAIK.

@timokau
Copy link
Member Author

timokau commented Oct 9, 2017

Oh I assumed that you just need to login to see the link. But you're right, a simple curl without being logged in doesn't work.

Then maybe I'll just write a more specific message explaining what to do and which file to choose.

@timokau
Copy link
Member Author

timokau commented Oct 14, 2017

I added a detailed message explaining the process and updated to the newest version. This should be ready to merge now.

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2017

Ok. I have no account there, but the code looks reasonable.

@Mic92 Mic92 merged commit 4a01ad0 into NixOS:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @orivej @Mic92 @Janik-Haag