Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.yowsup: init at v2.5.2 #30406

Merged
merged 2 commits into from Oct 14, 2017
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 14, 2017

Motivation for this change

The yowsup library is needed for the WhatsApp script provided by weechat: https://github.com/weechat/scripts/blob/master/python/whatsapp.py

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner October 14, 2017 09:25
src = pkgs.fetchFromGitHub {
owner = "tgalal";
repo = "yowsup";
rev = "v2.5.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just be rev = version;.

@@ -26537,6 +26537,30 @@ EOF
};
};

yowsup = buildPythonPackage rec {
Copy link
Member

@Mic92 Mic92 Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move new or updated expressions to pkgs/development/python-modules/<name>/default.nix. Please read the header of this file for further information.

@Ma27
Copy link
Member Author

Ma27 commented Oct 14, 2017

@Mic92 done :-)

@Mic92 Mic92 merged commit eef496f into NixOS:master Oct 14, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 14, 2017

Let me now, whether the weechat plugin is working well.

@Ma27 Ma27 deleted the init/python-yowsup branch October 14, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants