Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-applications: 17.08.1 -> 17.08.2 #30402

Merged
merged 1 commit into from Nov 3, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 14, 2017

Motivation for this change

KDE bugfix release

Announcement: https://www.kde.org/announcements/announce-applications-17.08.2.php

It's independent of #30305 but should be merged at the same time to make hydra work a bit less.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member Author

@ttuegel Can you have a look of this?

@adisbladis
Copy link
Member Author

@ttuegel @peterhoeg This one has now been laying around for 19 days. Can someone please merge?

I have rebased on current master.

@peterhoeg
Copy link
Member

You've been running this?

@adisbladis
Copy link
Member Author

@peterhoeg Yes been running it for quite some time.

@peterhoeg peterhoeg merged commit 19d67e1 into NixOS:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants