sqitch: fix on Darwin #30403
Merged
sqitch: fix on Darwin #30403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 14, 2017
| @@ -11,7 +11,9 @@ stdenv.mkDerivation { | |||
| installPhase = '' | |||
| mkdir -p $out/bin | |||
| for d in bin/sqitch etc lib share ; do | |||
| ln -s ${sqitchModule}/$d $out/$d | |||
| if [ -e ${sqitchModule}/$d ]; then | |||
There was a problem hiding this comment.
Can you add a comment or something? Otherwise it is not obvious why a condition is here.
There was a problem hiding this comment.
Yeah sure. The point is to prevent a share symlink from being created when it’s destination doesn’t exist (resulting in a collision).
There was a problem hiding this comment.
Yes, just a reference, that this happens on darwin.
There was a problem hiding this comment.
I'm pretty sure this is not darwin specific.
LnL7
approved these changes
Oct 14, 2017
matthewbauer
force-pushed
the
sqitch-fix
branch
from
e87c307
to
b5610ed
Compare
LnL7
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30389.