Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webos: init novacom, novacomd, cmake-modules; add nixos service #30057

Merged
merged 4 commits into from Feb 20, 2018
Merged

webos: init novacom, novacomd, cmake-modules; add nixos service #30057

merged 4 commits into from Feb 20, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 3, 2017

Motivation for this change

Add novacom, novacomd for communicating with WebOS devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm using the provided nixos service presently! 😁

@dtzWill
Copy link
Member Author

dtzWill commented Oct 3, 2017

The expressions work on 17.09 (it's how I'm running this currently)-- might this be cherry-picked onto 17.09?

@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2018

Ping! Not as useful as it would have been years ago but I still have a number of webOS devices I occasionally hack on.

@7c6f434c
Copy link
Member

@dtzWill so now you can review your own long-standing PRs and either declare them «trivial»/«enough feedback» and merge or add a «by: nixpkgs-member» label and an explanation why extra eyes are needed.

@dtzWill
nixos/release: Add novacomd
09e261c 
This is unlikely to break and is a cheap test.
I'd like to be notified if it stops working.

If this ever blocks anything and I've been notified
you have my blessing to remove this as I doubt
many folks depend on it.
@dtzWill
Copy link
Member Author

dtzWill commented Feb 20, 2018

@GrahamcOfBorg test novacomd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

syncing
machine: running command: sync
machine# [    5.944962] input: ImExPS/2 Generic Explorer Mouse as /devices/platform/i8042/serio1/input/input4
machine: exit status 0
test script finished in 6.82s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5a59c0437czfnkr04zvhvhh71niv0zhh-vm-test-run-novacomd

@dtzWill
Copy link
Member Author

dtzWill commented Feb 20, 2018

@GrahamcOfBorg build webos.novacom webos.novacomd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/8mhqxp9ns6f4agdz8jjrd2jkl2ll2nvj-novacom-18
/nix/store/bbl6lcz127381d4595pbm7c19cfdnrki-novacomd-127

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘novacom-18’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/mobile/webos/novacom.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/f256s2zs4cl5ab0kz90ya8ab7x3g1y33-novacom-18
/nix/store/1347xl8zwxdlf0avph3gp3ir181ssrmh-novacomd-127

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver/lib  /nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver/bin
patching script interpreter paths in /nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver
/nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/fcb8ic4792clqckbb30xk0qa56gps6ya-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/yq84xsz1i14dcjvvwpq1l3v0mmbikj0g-nixos-test-driver...
cannot build derivation '/nix/store/mz32byg1ii2543vnfxfjvxyff5g743d1-nixos-test-driver-novacomd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3ispid5iv55ph2x1gpa9lpxrpfyijdxv-vm-test-run-novacomd.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3ispid5iv55ph2x1gpa9lpxrpfyijdxv-vm-test-run-novacomd.drv' failed

@dtzWill
release: only run novacomd test on x86_64-linux
1bf5fae 
novacom and novacomd build on aarch64, but the daemon
fails to start with something like:

novacomd[547]: unhandled level 2 translation fault (11) at 0x00000000, esr 0x92000046

So, uh, nevermind that then.
@dtzWill dtzWill merged commit ce3de03 into NixOS:master Feb 20, 2018
@dtzWill dtzWill deleted the feature/webos-novacomd branch February 20, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @7c6f434c @GrahamcOfBorg