elixir: Fix locale problem on NixOS #30064
Conversation
| @@ -22,6 +22,7 @@ in | |||
|
|
|||
| buildInputs = [ erlang rebar makeWrapper ]; | |||
|
|
|||
| LOCALE_ARCHIVE = "${pkgs.glibcLocales}/lib/locale/locale-archive"; | |||
There was a problem hiding this comment.
Any ideas on a solution which would work both on Linux and on Mac osx?
There was a problem hiding this comment.
Build without this line: http://ix.io/AHh
Build with this line: http://ix.io/AHl
It definitely removes the warnings. I also inserted calls to locale in preBuild step and without this line the locale command were printout out warnings too. Can you suggest an alternative solution to get rid of the warnings?
There was a problem hiding this comment.
You can make add conditionally depending on the platform using stdenv.isLinux.
There was a problem hiding this comment.
@gleber sorry for the confusion, I was just suggesting to make it conditional with eg. stdenv.lib.optionalString stdenv.isLinux to avoid breaking the darwin build
|
Ah, I'll do that. I assumed that there's some magical generic solution :)
…On 4 Oct 2017 09:18, "Jörg Thalheim" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/interpreters/elixir/generic-builder.nix
<#30064 (comment)>:
> @@ -22,6 +22,7 @@ in
buildInputs = [ erlang rebar makeWrapper ];
+ LOCALE_ARCHIVE = "${pkgs.glibcLocales}/lib/locale/locale-archive";
You can make add conditionally depending on the platform using
stdenv.isLinux.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30064 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACBocZerQWm3fGn3VQsHzEERnWKgnD_ks5sozE8gaJpZM4Psc3L>
.
|
It looks like Erlang/OTP requires access to LOCALE_ARCHIVE for locales to correctly work. Elixir depends on this here: https://github.com/elixir-lang/elixir/blob/7a556b8f26f42f6b7510dc1d2351564d91ab746c/lib/elixir/src/elixir.erl#L76 Fixes NixOS#30047
|
Please take another look |
It looks like Erlang/OTP requires access to LOCALE_ARCHIVE for locales to correctly work. Elixir depends on this here:
https://github.com/elixir-lang/elixir/blob/7a556b8f26f42f6b7510dc1d2351564d91ab746c/lib/elixir/src/elixir.erl#L76
Fixes #30047
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)