pythonPackages.tensorflow: repair cuda-dependent variant #30058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge the outputs of cudatoolkit locally in the tensorflow derivation, using symlinkJoin Fixes NixOS#29798
|
@abbradar what do you think? |
|
I don't have access to my trusty nvidia yet, but the problem is that it cannot find the library at runtime, correct? If so, instead of using |
|
@abbradar adding both to the rpath actually did not work. Apparently this is due to a quirk in the pre-built tensorflow wheel. The |
|
Ah, no problem then. Looks good to me! |
|
Cheers, thanks for the feedback!
…On Thu, Oct 5, 2017 at 2:59 PM, Nikolay Amiantov ***@***.***> wrote:
Ah, no problem then. Looks good to me!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30058 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsY0roMNfvGFOer-q-nPDOOaEg9oEuks5spNLMgaJpZM4PsKEX>
.
|
|
@FRidh Any chance to merge this? Or is someone else in charge? |
|
Tested that it imports but not runs (trust you have tested this with CUDA). Thank you! |
andersk
added a commit
to andersk/nixpkgs
that referenced
this pull request
Apr 7, 2018
Similar to NixOS#30058 for TensorFlow. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
FRidh
pushed a commit
that referenced
this pull request
May 4, 2018
* pytorch-0.3 with optional cuda and cudnn
* pytorch tests reenabled if compiling without cuda
* pytorch: Conditionalize cudnn dependency on cudaSupport
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: Compile with the same GCC version used by CUDA if cudaSupport
Fixes this error:
In file included from /nix/store/gv7w3c71jg627cpcff04yi6kwzpzjyap-cudatoolkit-9.1.85.1/include/host_config.h:50:0,
from /nix/store/gv7w3c71jg627cpcff04yi6kwzpzjyap-cudatoolkit-9.1.85.1/include/cuda_runtime.h:78,
from <command-line>:0:
/nix/store/gv7w3c71jg627cpcff04yi6kwzpzjyap-cudatoolkit-9.1.85.1/include/crt/host_config.h:121:2: error: #error -- unsupported GNU version! gcc versions later than 6 are not supported!
#error -- unsupported GNU version! gcc versions later than 6 are not supported!
^~~~~
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: Build with joined cudatoolkit
Similar to #30058 for TensorFlow.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: 0.3.0 -> 0.3.1
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: Patch for “refcounted file mapping not supported” failure
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: Skip distributed tests
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
* pytorch: Use the stub libcuda.so from cudatoolkit for running tests
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge the outputs of cudatoolkit locally in the tensorflow
derivation, using symlinkJoin
Fixes #29798
Motivation for this change
See #29798
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)