Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert EthernetInterface to use a builder pattern #47

Closed
whitequark opened this issue Oct 3, 2017 · 2 comments
Closed

Convert EthernetInterface to use a builder pattern #47

whitequark opened this issue Oct 3, 2017 · 2 comments

Comments

@whitequark
Copy link
Contributor

The type signature of new is getting really unwieldy, and the breaking changes for every new features are undesirable.

@dlrobertson
Copy link
Collaborator

This is going to be super important as we move towards adding IPv6 support. Especially once builds without the future proto-ipv4 become a possibility.

@dlrobertson
Copy link
Collaborator

In fact, this should probably be done before we add the proto-ipv4 feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants