Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchpatch: allow callers to specify postFetch sensibly #30063

Merged
merged 1 commit into from Oct 4, 2017
Merged

fetchpatch: allow callers to specify postFetch sensibly #30063

merged 1 commit into from Oct 4, 2017

Conversation

copumpkin
Copy link
Member

Before this fix, it seemed to be trying to merge our postFetch with the patch normalization logic, but accidentally clobbering the whole thing with the passed-in value.

Motivation for this change

I tried to pass in postFetch but it clobbered the patch normalization logic, causing the hash to change.

@copumpkin
fetchpatch: allow callers to specify postFetch sensibly
dd8a42a 
Before this fix, it seemed to be trying to merge our postFetch with the
patch normalization logic, but accidentally clobbering the whole thing
with the passed-in value.
@copumpkin copumpkin merged commit acedcc9 into NixOS:master Oct 4, 2017
@copumpkin
Copy link
Member Author

Thanks @orivej!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
6.topic: fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@copumpkin @orivej @lukateras