Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: Add test #30060

Closed
wants to merge 1 commit into from
Closed

mariadb: Add test #30060

wants to merge 1 commit into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

So we can check that future PRs really work

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Oct 4, 2017

Well, pkgs.mysql is actually mariadb, so we're testing mariadb in the mysql test. So we don't need this test. This confusing situation needs some major cleanup for 18.03.

@fpletz fpletz closed this Oct 4, 2017
@NeQuissimus
Copy link
Member Author

@fpletz oO that is indeed confusing :D

@NeQuissimus NeQuissimus deleted the mariadb_test branch October 4, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @fpletz