Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arelle: 2017-08-24 -> 2017-10-07 #30272

Closed
wants to merge 1 commit into from
Closed

arelle: 2017-08-24 -> 2017-10-07 #30272

wants to merge 1 commit into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 10, 2017

  • Redundant \m issue has been solved, simplifying patch
  • Patch now only concerns imports, so renaming
  • The py3to2 tool is not a dependency any more
  • Sadly, the imports are broken again in Python >=3.5.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member Author

roberth commented Oct 10, 2017

Travis fails because nox wants to build python27Packages.arelle, python36Packages.arelle etc, which are now disabled. I have tested arelle (= python34Packages.arelle) on NixOS.

Mic92
Mic92 reviewed Oct 14, 2017
View reviewed changes
pkgs/development/python-modules/arelle/default.nix Outdated

disabled = !isPy3k;
# Import semantics have changed in python 3.5. Upstream uses python 3.4.
disabled = !isPy3k && (!pythonAtLeast "python35");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It stills tries to build for python 3.6 on my system. How about using isPy34 instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I should have thought a bit more deeply about all those negations... I'm going for isPy34 instead. I didn't like pythonAtLeast anyway.

@roberth
arelle: 2017-08-24 -> 2017-10-07
da5fc27 
 * Redundant \m issue has been solved, simplifying patch
 * Patch now only concerns imports, so renaming
 * The py3to2 tool is not a dependency any more
 * Sadly, the imports are broken again in Python >=3.5.
@roberth
Copy link
Member Author

roberth commented Oct 16, 2017

No, wait, py36 is working again. Either someone fixed a python interpreter problem, or this thing is somehow nondeterministic.

@roberth roberth closed this Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @Mic92