Use query string from WebSocket URI-based instantiation #5095
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackturnbull
changed the title
|
Thanks! |
|
Yeah not a problem! I'm tethered to my phone at the minute so will get one together when I can run it locally |
|
I just pushed a commit which adds specs to this PR for you. |
When instantiating a WebSocket using separate parameters for host and path, it is possible to pass in a query string to the connection by appending it to the end of the path parameter. This is effectively stripped out when is passed through as a URI since the `path` call on the URL does not return the query string. Fixed by calling `full_path` instead of `path` on the given URI.
|
Nice one, thanks! Was just about to look at it but saved me a job :) |
RX14
approved these changes
Oct 13, 2017
jhass
approved these changes
Oct 13, 2017
RX14
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiating a WebSocket using separate parameters for host and path, it is possible to pass in a query string to the connection by appending it to the end of the path parameter. This is effectively stripped out when is passed through as a URI since the
pathcall on the URL does not return the query string.Fixed by calling
full_pathinstead ofpathon the given URI.See: #3234 for further and working example