[NixOS-17.09] Fix graphite crash by upgrading from 0.9.15 -> 1.0.2 #30277
Conversation
Fixes: NixOS#29961 Also added the option: services.graphite.web.extraConfig for configuring graphite_web.
| }; | ||
| propagatedBuildInputs = with self; [ django ]; | ||
| propagatedBuildInputs = with self; [ django_1_8 ]; |
There was a problem hiding this comment.
@basvandijk this is incorrect; we don't depend on specific versions. Instead, when you need this package with this version of Django the package set needs to be overridden. Can you open a PR with a fix?
There was a problem hiding this comment.
@FRidh I see your point. I see that we only use django_tagging_0_4_3 inside graphite_web so what about remove that attribute altogether and doing the override locally in graphite_web like: master...LumiGuide:django_tagging-0.4.3_refactor ?
There was a problem hiding this comment.
What if I then do python.withPackages(ps: with ps; [ graphite_web django_tagging ]). Then I'll get two versions of django_tagging in a closure. We can't have that!
The only solution to picking the correct versions is overriding the package set, e.g. python.override { packageOverrides = super: self: { }; }
There was a problem hiding this comment.
@FRidh good point. Will you be at NixCon this weekend? If so, it would be cool if you could explain to me how to accomplish this.
instead of depending on specific versions in the django_tagging_0_4_3 and graphite_web derivations. This should fix: NixOS#30277 (comment) This was joint work of @basvandijk and @layus at NixCon 2017.
This is a cherry-pick of #30166 on
release-17.09. The testnix-build nixos/release.nix -A tests.graphitesucceeds.It would be great if both PRs could be merged.