Fix pkgconfig reference for emacs-packages.nix
#30279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I suppose this means we should make the tarball job eval this too? |
|
Err, I'm not 100% sure what you mean by that. |
|
The builds fail to find `pkgconfig` and complain, but happen to build.
After fixing a few cases where failure to find pkgconfig lead to failed
build, I decided to fix the two remaining cases before I forget why this
situation has appeared.
|
|
I meant that the normal "does nixpkgs eval?" test should pick this up, but evidently didn't or I would have noticed it. |
|
Well, `let` and attrset have similar syntax…
This didn't break eval, this did break a couple of builds, but that is
a hard problem to test quickly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In 531e4b8 @Ericson2314 made an edit that causes
pkgs/top-level/emacs-packages.nixto be unevaluatable. This fixes it.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)