Skip to content

watson-ruby: init at 1.6.3 #29702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2017
Merged

watson-ruby: init at 1.6.3 #29702

merged 4 commits into from
Sep 25, 2017

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Package the inline issue manager Watson

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@robertodr robertodr changed the title watson: init at 1.6.3 watson-ruby: init at 1.6.3 Sep 23, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2017

Can you also add a package to all-packages.nix? Otherwise nobody can install your package.

description = "An inline issue manager";
homepage = http://goosecode.com/watson/;
license = with licenses; mit;
maintainers = with maintainers; [ robertodr ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to declare this maintainer in lib/maintainers.nix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer declared. I also sorted the list of maintainers.

robertodr and others added 4 commits September 25, 2017 14:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bundlerEnv also comes with a bundle script and ruby libraries
@Mic92 Mic92 merged commit 8a1fb4b into NixOS:master Sep 25, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants