Fix exception declaration in base class, as subclasses in svg.pxd require it. #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire it. This will become an error in Cython 0.27, as it would depend on the type that Cython thinks it is calling (base or subtype) whether exceptions will be handled by the caller or not.
|
Looks like further changes in other .pxd files are also needed ( |
|
The current change throws an error during compilation unfortunately(as you've mentioned), so I can't merge it in its current state, but afaik, this change is harmless (ref #5220) except that it required switching to higher version of Cython. If you're willing, please make similar changes to the files Travis build complains about, so that it can be merged. Thanks :) |
This was referenced Sep 25, 2017
Merged
|
Closing in favour of #5406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will become an error in Cython 0.27, as it would depend on the type that Cython thinks it is calling (base or subtype) whether exceptions will be handled by the caller or not.