Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don t drop SDL_Dropfile event while in pause #5388 #5389

Merged
merged 2 commits into from Sep 30, 2017

Conversation

brvier
Copy link
Contributor

@brvier brvier commented Sep 21, 2017

We need to catch the dropfile event sent by SDL even in Pause for inter app communication with scheme URI (qrcode from camera from example on iOS) #5388

@brvier brvier changed the title Don t drop SDL_Dropfile event while in pause #5388 Don t drop SDL_Dropfile event while in pause https://github.com/kivy/kivy/issues/5388 Sep 21, 2017
@brvier brvier changed the title Don t drop SDL_Dropfile event while in pause https://github.com/kivy/kivy/issues/5388 Don t drop SDL_Dropfile event while in pause #5388 Sep 21, 2017
@KeyWeeUsr
Copy link
Contributor

I can't really test it because I don't have Apple device, but if someone can confirm it works (@khertan, an example to reproduce would be really really nice) it should be ok to merge. Seems like a good change and perhaps there's a use for it even on Android, @inclement?

@brvier
Copy link
Contributor Author

brvier commented Sep 24, 2017 via email

@KeyWeeUsr KeyWeeUsr merged commit e2f86de into kivy:master Sep 30, 2017
@KeyWeeUsr
Copy link
Contributor

Thanks! 🍡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants