Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc prebuilt: Normalize style without changing hashes #29708

Merged
merged 4 commits into from Sep 23, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 23, 2017

Motivation for this change

This is the first part of #29688. Merging to master, and probably back-porting, so future work is easier to port between ghc and nixpkgs versions with, e.g.

git diff pkgs/develop/compiler/ghc/foo | sed 's/-a.b.c/v-x.y.z/' | git apply -3
Things done

No hashes are changed.


This looks like a WIP attempt from 2008
This removes noise in the diff, making creating new versions easier. No
hashes should be changed.
If I'm going to make a bunch more of these, I think it's a good idea to
make them more uniform first.
Doing this separately so the other commits are more readable
@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @shlevy and @MarcWeber to be potential reviewers.

@Ericson2314 Ericson2314 merged commit 8326c42 into NixOS:master Sep 23, 2017
@Ericson2314 Ericson2314 deleted the ghc-prebuilt-indent branch September 23, 2017 17:04
@Ericson2314 Ericson2314 added 8.has: port to stable A PR already has a backport to the stable release. 9.needs: port to stable A PR needs a backport to the stable release. and removed 8.has: port to stable A PR already has a backport to the stable release. labels Sep 23, 2017
@Ericson2314
Copy link
Member Author

@globin @fpletz what do you two say on the backport? The whole thing would be a haskell mass rebuild and not good for 17.09, but this is just moving code around.

Ericson2314 added a commit that referenced this pull request Sep 23, 2017
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants