Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4f5192993ebc
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02d79be0f859
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 24, 2017

  1. Add virtual destructor to Renderer

    @ts826848
    ts826848 authored Sep 24, 2017
    Copy the full SHA
    c0e8d76 View commit details

  2. Remove blank at end of line.

    @pleroy
    pleroy authored Sep 24, 2017
    Copy the full SHA
    8d55aa5 View commit details

  3. Merge pull request #1579 from aw1621107/patch-1 

    Add virtual destructor to Renderer
    @pleroy
    pleroy authored Sep 24, 2017
    Copy the full SHA
    02d79be View commit details
Showing with 2 additions and 0 deletions.
  1. +2 −0 ksp_plugin/renderer.hpp
2 changes: 2 additions & 0 deletions ksp_plugin/renderer.hpp
View file
Original file line number Diff line number Diff line change
@@ -40,6 +40,8 @@ class Renderer {
Renderer(not_null<Celestial const*> sun,
not_null<std::unique_ptr<NavigationFrame>> plotting_frame);

virtual ~Renderer() = default;

// Changes the plotting frame of the renderer.
virtual void SetPlottingFrame(
not_null<std::unique_ptr<NavigationFrame>> plotting_frame);