Update buildozer.spec #370
Conversation
|
sorry, I do not understand what's going here please anyone tell me |
|
@sandeepsajan0 It's just a bot. To know more visit coverals.io. |
examples/camera/basic/buildozer.spec
Outdated
| # (list) Application requirements | ||
| requirements = plyer,kivy | ||
| # (list) Application requirements | ||
| # android is also require for run this app on android |
There was a problem hiding this comment.
Grammar mistake :P . android library is also required to run this app on Android platform might be better.
examples/camera/basic/buildozer.spec
Outdated
| requirements = plyer,kivy | ||
| # (list) Application requirements | ||
| # android is also require for run this app on android | ||
| requirements = plyer,kivy,android |
There was a problem hiding this comment.
I don't think there is need to mention android in requirements since this buildozer.spec can also be used to create iOS app. Just informing the user with the help of comment will be enough.
requirements should contain the common libraries which are required for both Android and iOS.
There was a problem hiding this comment.
ok, I have done it.
now it should be fine.
|
@Malverick I think it will be fine now. |
|
Now, I think it should be merge, if not tell me the reason, please. |
|
I understand what you are trying to do here, but right now this is just a comment. How about a new pr? where you actually add Start with a new branch and do a new pr with just one commit, plus add comments on why this change was needed. looking forward to your new pr. |
|
Yes, you are right but if I actually add |
|
ok, then please squash the commits into one. This would help us get a clean history. |
|
@akshayaurora You can still change the merging type to |
|
@akshayaurora can I squash the commits of closed pull request? |
|
@sandeepsajan0 afaik yeah, but if you push them back to remote ( |
|
Thanks! :) |
now camera facade of plyer(kivy) works well on android also.