Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors caused by python_recipe being None #1121

Closed
wants to merge 1 commit into from
Closed

Fix errors caused by python_recipe being None #1121

wants to merge 1 commit into from

Conversation

kdheepak
Copy link

No description provided.

@inclement
Copy link
Member

Thanks for the contribution. Is this to make the build work if you don't actually include python in the built dist?

@kdheepak
Copy link
Author

This was because I was getting error similar to #620 and I had to check for if python_recipe was not None to proceed. I still wasn't able to build an apk because I was getting some other error, so perhaps I may have been missing something fundamental.

@inclement inclement modified the milestones: 0.6, 0.7 Nov 19, 2017
@ghost
Copy link

ghost commented Apr 4, 2019

This seems to be pretty old and lots of things changed regarding the affected code specifically of how the python recipes interact. Is this still issue still present and in need of fixing for latest p4a?

@ghost ghost added the awaiting-reply label Apr 4, 2019
@kdheepak
Copy link
Author

kdheepak commented Apr 4, 2019

I haven't used this in a while, so we can close this. If I remember correctly, I was trying some odd combination of inputs for iOS or Android, and that's why that variable was ending up as None.

@kdheepak kdheepak closed this Apr 4, 2019
@kdheepak kdheepak deleted the fix-python-recipe-none-error branch April 4, 2019 17:52
@ghost
Copy link

ghost commented Apr 4, 2019

thanks for the quick feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants