GDM fixes #29697
Merged
GDM fixes #29697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
requested review from
copumpkin,
edolstra,
edwtjo,
FRidh,
LnL7 and
peti
as code owners
zimbatm
force-pushed
the
gdm-on-nvidia
branch
6 times, most recently
from
333dd65
to
39f39b4
Compare
|
we are still trying to fix the gnome3-gdm tests |
zimbatm
force-pushed
the
gdm-on-nvidia
branch
from
39f39b4
to
e925a95
Compare
|
@zimbatm you might want to be explicit about i.e. [daemon]
- WaylandEnable=${toString cfg.gdm.wayland}
+ WaylandEnable=${if cfg.gdm.wayland then "true" else "false"}
${optionalString cfg.gdm.autoLogin.enable ( |
zimbatm
force-pushed
the
gdm-on-nvidia
branch
from
e925a95
to
c449f5f
Compare
|
Any idea why it seems to think I'm an owner here? |
|
I don't know, when I created the issue, a bunch of people were automatically added as reviewers |
|
Probably because the base branch was incorrect the first time, GitHub though you're proposing to submit every single commit from 17.09 in master. |
|
anyone with a nvidia card wants to test this? |
fpletz
force-pushed
the
gdm-on-nvidia
branch
from
c449f5f
to
0cad98d
Compare
|
Should be fine. Thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a rework of #25621
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)