Xinetd #29699
Closed
Xinetd #29699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92, @7c6f434c and @thoughtpolice to be potential reviewers. |
|
Sorry, my initial push contained updates to gambit and gerbil that are not to be included in this PR (waiting for gambit release to push something stable). I pushed --force an update with just the xinetd updates. |
|
There's a lot of raw text in there - I suggest creating a function that generates the text for the services instead. |
matthewbauer
requested changes
Apr 21, 2018
|
Yes, I need to address these issues indeed. |
|
(triage) should this be closed until someone has time to do the refactoring? |
|
Closing for now. I will reopen later, if I find time to work on it again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
xinetd has internal services that some legacy software uses, and that I enable at home.
Things done
I actually tested my renaming xinetd to MYxinetd and importing using imports in my configuration.nix.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)