Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: amdgpu-pro update #29698

Closed
wants to merge 1 commit into from
Closed

wip: amdgpu-pro update #29698

wants to merge 1 commit into from

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Sep 23, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pstn
Copy link
Contributor

pstn commented Sep 23, 2017

error: syntax error, unexpected ')', expecting ';', at [...]/nixpkgs/pkgs/os-specific/linux/amdgpu-pro/default.nix:63:4

I don't know how to send you the correct version, via git here, so I guess it's easier if you fix that simple yourself.

@corngood
Copy link
Contributor Author

Thanks, fixed. So far I've tested:

  • xorg 1.19
  • opengl (glxgears etc)
  • vdpau (mpv)

I haven't got around to testing the 32-bit stuff, opencl, or vulkan, so if you verify any of those, let me know.

Make sure you are using the custom 4.10 kernel it provides. It won't work without KALLSYMS_ALL y.

@pstn
Copy link
Contributor

pstn commented Sep 23, 2017

An error message I got during installation

gzipping man pages under /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/share/man/
stripping (with flags -S) in /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/lib  /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/bin
patching script interpreter paths in /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16
/nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/bin/amdgpu-pro-px: interpreter directive changed from "/bin/bash" to "/nix/store/m2yxakijvp9db943qf8a0qbchyyg3dsn-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-amdgpu-pro-17.30-4.10.16.drv-0 in /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16...
Can't open /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/lib/libgbm_amdgpu.so.1.0.0: No such file or directory.
Can't open /nix/store/mip7237f50sxmqxf78hdc1s228bvwfw1-amdgpu-pro-17.30-4.10.16/lib/libkms_amdgpu.so.1.0.0: No such file or directory.
building path(s) ‘/nix/store/jp05d74byxpdk11b1164zs06xr9gyd8y-firmware’

I don't know if it's important but I thought I paste it here before rebooting.

@pstn
Copy link
Contributor

pstn commented Sep 23, 2017

I could verify that vulkan works on 32Bit and 64Bit and opengl works on 32Bit.

@corngood
Copy link
Contributor Author

@pstn Any problems so far?

@pstn
Copy link
Contributor

pstn commented Sep 25, 2017 via email •
edited

@pstn
Copy link
Contributor

pstn commented Sep 28, 2017

I have no idea how to test opencl. So I tried:

[myprompt:~]$ nix-shell -p opencl-info
[nix-shell:~]$ opencl-info
ERROR: clGetPlatformIDs(-1001)

So I guess there is something wrong there.

Other than that I didn't encounter anything that would prohibit a merge.

corngood
corngood commented Oct 3, 2017
View reviewed changes
nixos/modules/hardware/video/amdgpu-pro.nix
@@ -31,17 +35,25 @@ in

boot.extraModulePackages = [ package ];

boot.kernelPackages =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat What do you think of this? It feels wrong, but this kernel module requires linux 4.10 w/ KALLSYMS_ALL=y, and I couldn't find a precedent for influencing the kernel config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, 4.10 branch was killed upstream, and we already deleted it in nixpkgs as well. Second, just the fact of users having to build their own kernel would be quite a nuisance. Perhaps it would be good to look into the suitability of having the option in default kernels (say those > 4.9).

Copy link
Member

@vcunat vcunat Oct 5, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.13 is the only maintained branch newer than 4.9 ATM (4.9 is the latest longterm branch).

@andrewchambers andrewchambers mentioned this pull request Nov 14, 2017
Closed
8 tasks
@corngood corngood closed this Jan 10, 2018
@corngood corngood mentioned this pull request Jan 10, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @pstn @vcunat