Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpad: init at 5.0.0 #29720

Merged
merged 2 commits into from Sep 24, 2017
Merged

xpad: init at 5.0.0 #29720

merged 2 commits into from Sep 24, 2017

Conversation

michalrus
Copy link
Member

Motivation for this change

We only have gnome3.bijiben which is worse! (ﾉ^_^)ﾉ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

vyp
vyp reviewed Sep 24, 2017
View reviewed changes
pkgs/applications/misc/xpad/default.nix Outdated
'';

meta = with stdenv.lib; {
description = "Xpad is a sticky note application for jotting down things to remember.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should not start with the package name and should not have a period at the end. No big deal obviously but this is mentioned in CONTRIBUTING.md btw, which you checked off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I needed it fast in Nixpkgs and just copied mindlessly from upstream! Will fix in a sec.

@Mic92 Mic92 merged commit 0e71e03 into NixOS:master Sep 24, 2017
@michalrus michalrus deleted the xpad branch September 24, 2017 10:29
@michalrus
Copy link
Member Author

michalrus commented Sep 24, 2017 •
edited

@Mic92, thanks a lot! =) But how did you know to wrapGApps? It seemed to work fine without it.

globin pushed a commit that referenced this pull request Sep 24, 2017
@michalrus @globin
xpad: init at 5.0.0 (#29720)
7efb9fa 
* xpad: init at 5.0.0

* xpad: wrapGAppsHook is required

(cherry picked from commit 0e71e03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalrus @vyp @Mic92