WIP salt: fix patch once more, now using EAFP #29723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NixOS#29020 Patch introduced in PR NixOS#29020 was OK when installing salt on NixOS, but on Linux behavior was switched to less pure variant. Here I'm returning back original behavior (use hardcoded path to `libcrypto` by default), but don't disallow dynamic library lookups (which was essential for `salt-ssh`). "Easier to Ask Forgiveness than Permission" principle at work.
|
@danbst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aneeshusa to be a potential reviewer. |
|
I'm going to do some tests soon, so don't merge now please. |
danbst
changed the title
8 tasks
|
Closing in favor of #33971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29020 (comment)
Patch introduced in PR #29020 was OK when installing salt on NixOS, but on Linux
behavior was switched to less pure variant. Here I'm returning back original
behavior (use hardcoded path to
libcryptoby default), but don't disallow dynamiclibrary lookups (which was essential for
salt-ssh)."Easier to Ask Forgiveness than Permission" principle at work.