Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "nixos: add option for bind to not resolve local queries (#29503…
…)" This reverts commit 670b4e2. The change added in this commit was controversial when it was originally suggested in #29205. Then that PR was closed and a new one opened, #29503, effectively circumventing the review process. I don't agree with this modification. Adding an option 'resolveLocalQueries' to tell the locally running name server that it should resolve local DNS queries feels outright nuts. I agree that the current state is unsatisfactory and that it should be improved, but this is not the right way.
- Loading branch information
Showing
4 changed files
with
3 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23a021d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peti, Please don't feel that my closing of the old PR as a way to bypass the review process.
I never had that intention. I closed it because I made a mess of the original PR. Besides, I linked both PR's to the other for continuity.
I took your comment of not breaking existing systems to heart and changed the way the Bind-service gets handled to be identical to Dnsmasq. The breaking assertion I removed. In fact my patch makes sure that your system (and those of others) don't break while letting me run Bind in a non-resover role.
Please read my patch again and check if it would break on your configuration.