Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "nixos: add option for bind to not resolve local queries (#29503…
…)" This reverts commit 670b4e2. The change added in this commit was controversial when it was originally suggested in #29205. Then that PR was closed and a new one opened, #29503, effectively circumventing the review process. I don't agree with this modification. Adding an option 'resolveLocalQueries' to tell the locally running name server that it should resolve local DNS queries feels outright nuts. I agree that the current state is unsatisfactory and that it should be improved, but this is not the right way. (cherry picked from commit 23a021d)
- Loading branch information
Showing
4 changed files
with
3 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99f759d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peti,
Please don't treat my pulling back the old PR as a way to circumvent the review process. I messed it up and could not figure out how to resolve that. That's why I created a new PR. And I linked it to the new one to continue the discussion.
About the patch: I copied the existing behaviour for DNSMASQ and made sure that Bind operates the same way. It may be the wrong solution, but at least it is more consistent than before my patch. Don't let the perfect be the enemy of the good.
Please reconsider and accept my patch.