Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pyscss: 1.3.4 -> 1.3.5 #29701

Merged
merged 1 commit into from Sep 24, 2017
Merged

python.pkgs.pyscss: 1.3.4 -> 1.3.5 #29701

merged 1 commit into from Sep 24, 2017

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 23, 2017

this also:

  • enables tests (properly)
  • fixes build on python 3.6
Motivation for this change

Hydra's build for py3.6 was failing. Turns out it wasn't even executing the tests properly. Bumped version works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • [ x Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@risicle
python.pkgs.pyscss: 1.3.4 -> 1.3.5
a358c43 
this also:
 - enables tests (properly)
 - fixes build on python 3.6
@risicle risicle requested a review from FRidh as a code owner September 23, 2017 14:53
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 24, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2017

also part of #28643

@Mic92 Mic92 merged commit c355524 into NixOS:master Sep 24, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2017

done in 40b0653

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @Mic92 @samueldr