Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbfs: 20170429.44efa06 -> 20170922.f76290 #29716

Merged
merged 1 commit into from Sep 24, 2017
Merged

kbfs: 20170429.44efa06 -> 20170922.f76290 #29716

merged 1 commit into from Sep 24, 2017

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Sep 23, 2017

Motivation for this change

kbfs was not working with the lastest keybase update
(ef3cb5c).

We should enforce update of keybase/keybase-ui and kbfs (like done here:
f74a1e6)
all together to avoid API problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jfroche
Update kbfs: 20170429.44efa06 -> 20170922.f76290
11d68e9 
kbfs was not working with the lastest keybase update
(NixOS@ef3cb5c).

We should enforce update of keybase/keybase-ui and kbfs (like done here:
NixOS@f74a1e6)
all together to avoid API problems.
@mention-bot
Copy link

@jfroche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bennofs, @np and @SuprDewd to be potential reviewers.

@zimbatm zimbatm merged commit b50ae94 into NixOS:master Sep 24, 2017
@zimbatm
Copy link
Member

zimbatm commented Sep 24, 2017

makes sense. In that case it would be better to maintain them all in the same folder.

zimbatm pushed a commit that referenced this pull request Sep 24, 2017
@jfroche @zimbatm
Update kbfs: 20170429.44efa06 -> 20170922.f76290 (#29716)
773e5dd 
kbfs was not working with the lastest keybase update
(ef3cb5c).

We should enforce update of keybase/keybase-ui and kbfs (like done here:
f74a1e6)
all together to avoid API problems.

(cherry picked from commit b50ae94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfroche @mention-bot @zimbatm