latte dock: 0.6.0 -> 0.7.1 #29730
Merged
latte dock: 0.6.0 -> 0.7.1 #29730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DIzFer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vandenoever, @ttuegel and @benley to be potential reviewers. |
Mic92
reviewed
Sep 24, 2017
| buildInputs = [ plasma-framework xorg.libpthreadstubs xorg.libXdmcp ]; | ||
| buildInputs = [ plasma-framework xorg.libpthreadstubs xorg.libXdmcp xorg.libSM ]; | ||
|
|
||
| # cmakeFlags = [ "-DCMAKE_BUILD_TYPE=Debug" ]; |
There was a problem hiding this comment.
If you mean the cmakeFlags comment, then no. I had some issues having latte run and it's an unintended leftover from testing.
There was a problem hiding this comment.
Also, I'm probably messing something up with the differences between buildInputs and nativeBuildInputs :(
DIzFer
force-pushed
the
latte-dock-update
branch
from
76b735f
to
4105d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)