Skip to content

Turn loop variable copies to references #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 24, 2017
Merged

Turn loop variable copies to references #1580

merged 14 commits into from
Sep 24, 2017
+18 −15

Conversation

ts826848
Copy link
Contributor

I was less certain that these changes were right, so each file changed got its own commit to help with future bisecting.

@pleroy
Copy link
Member

pleroy commented Sep 24, 2017

Can one of the admins verify this patch?

@eggrobin
Copy link
Member

As discussed on IRC, we don't use not_null<T*> const&, on the other hand we try to make those explicit rather than auto, precisely so we aren't tempted to add a &, so it might be a good idea to change those that use auto, for consistency (e.g., PileUp has both auto const and not_null<Part*> const for iterating on parts_.

@pleroy
Copy link
Member

pleroy commented Sep 24, 2017

ok to test

@pleroy
Copy link
Member

pleroy commented Sep 24, 2017

ok to test

@pleroy pleroy added the LGTM label Sep 24, 2017
@pleroy
Copy link
Member

pleroy commented Sep 24, 2017

Thanks for all your contributions. Much appreciated.

Sorry, something went wrong.

@pleroy pleroy merged commit bf6a1c5 into mockingbirdnest:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleroy pleroy

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ts826848 @pleroy @eggrobin