Skip to content

Fix the remaining Clang warnings #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pleroy opened this issue Sep 24, 2017 · 1 comment
Closed

Fix the remaining Clang warnings #1581

pleroy opened this issue Sep 24, 2017 · 1 comment
Assignees

Comments

@pleroy
Copy link
Member

pleroy commented Sep 24, 2017

A list of interesting warnings that we probably want to fix (not necessarily complete because sifting through the logs is hard):

./quantities/parser_body.hpp:24:13: warning: suggest braces around initialization of subobject [-Wmissing-braces]
    return {0, 0, 0, 0, 0, 0, 0, 0};
            ^~~~~~~~~~~~~~~~~~~~~~
            {                     }
./quantities/parser_body.hpp:46:13: warning: suggest braces around initialization of subobject [-Wmissing-braces]
    return {LengthExponent,
            ^~~~~~~~~~~~~~~
astronomy/ksp_system_test.cpp:502:43: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
            /*first_step_in_seconds=*/75}));
astronomy/solar_system_dynamics_test.cpp:581:43: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
            /*first_step_in_seconds=*/75}));
                                          ^
integrators/symplectic_runge_kutta_nyström_integrator_test.cpp:724:46: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
                        ValuesIn(Instances()));
integrators/symmetric_linear_multistep_integrator_test.cpp:452:46: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
                        ValuesIn(Instances()));
physics/ephemeris_test.cpp:1021:59: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
        &Quinlan1999Order8A<Position<ICRFJ2000Equator>>()));
./base/array_body.hpp:48:13: warning: suggest braces around initialization of subobject [-Wmissing-braces]
    : data_{std::forward<Args>(args)...},
            ^~~~~~~~~~~~~~~~~~~~~~~~
            {                       }
ksp_plugin_test/interface_renderer_test.cpp:49:11: warning: unused variable 'trajectory_size' [-Wunused-const-variable]
int const trajectory_size = 10;
          ^
ksp_plugin_test/interface_renderer_test.cpp:51:5: warning: unused variable 'parent_position' [-Wunused-variable]
XYZ parent_position = {4, 5, 6};
    ^
./base/array_body.hpp:48:13: warning: suggest braces around initialization of subobject [-Wmissing-braces]
    : data_{std::forward<Args>(args)...},
            ^~~~~~~~~~~~~~~~~~~~~~~~
            {                       }
@eggrobin
Copy link
Member

I don't think we want to fix Wgnu-zero-variadic-macro-arguments in INSTANTIATE_TEST_CASE_P.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants