routino: init at 3.2 #29755

dotlambda · 2017-09-24T23:07:07Z

Motivation for this change

I need this for QMapShack, which I want to package next.

Even though the installation instructions talk about setting up a web interface, I have no use for this and I even don't know how to package that properly. Therefore I just didn't care about it.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

vyp · 2017-09-24T23:15:40Z

pkgs/tools/misc/routino/default.nix

+{ stdenv, fetchsvn, perl, zlib, bzip2 }:
+
+stdenv.mkDerivation rec {
+  name = "Routino-${version}";


Lowercase routino? (Possible typo?) If not sorry for the noise.

https://nixos.org/nixpkgs/manual/#sec-package-naming :

Don’t use uppercase letters in the name attribute — e.g., "mplayer-1.0rc2" instead of "MPlayer-1.0rc2".

dotlambda · 2017-09-25T05:56:22Z

Do you think it should be uppercase everywhere, even in all-packages.nix?
Or do you wonder why I made it uppercase in the name?

vyp · 2017-09-25T08:16:06Z

Just the latter, sorry I wasn't clear.

dotlambda · 2017-09-25T08:55:14Z

I did this because they write Routino in their documentation:

With Routino the tagging rules are contained in a configuration file

dotlambda · 2017-09-25T15:19:23Z

You can merge this now

dotlambda · 2017-09-28T12:08:58Z

ping

vyp · 2017-09-28T12:11:29Z

(I can't merge btw, no commit rights.)

orivej · 2017-09-28T12:26:11Z

pkgs/tools/misc/routino/default.nix

+  version = "3.2";
+
+  src = fetchsvn {
+    url = "http://routino.org/svn/trunk/";


Why not http://routino.org/download/routino-3.2.tgz ?

You're right, that's more elegant.

orivej · 2017-09-28T12:32:39Z

pkgs/tools/misc/routino/default.nix

+    make DESTDIR="$out" install
+    mv $out/usr/local/* $out
+    rmdir $out/usr/local $out/usr
+  '';


Replace this with makeFlags = [ "prefix=$out" ];.

I could indeed do installFlags = [ "DESTDIR=$out" ];.
But nevertheless, the install target creates a directory $out/usr/local from which I can move the content to $out in the postInstall phase.

I'm just remebering that this doesn't work either:
I intentionally wrote make DESTDIR="$out" install since if I don't quote the variable, the package is installed to a directory called ut/.
I tried every way of escaping/quoting I was able to come up with:

installFlags = [ ''DESTDIR="$out"'' ]

installFlags = [ "DESTDIR=\$out" ]

...

but the package is always installed to ut/.
Do you have an idea?

No, that /usr/local comes from the default prefix in the Makefile. If you define it with makeFlags = [ "prefix=$out" ];, you will not have to override DESTDIR.

You're absolutely right, but makeFlags = [ "prefix=$out" ]; won't work.
For some strange reason, you need "prefix=$(out)".

Sorry, prefix indeed is not overridable with a make flag. I would try substituteInPlace Makefile.conf --replace prefix=/usr/local prefix=$outin the postPatch phase.

orivej · 2017-09-28T12:34:00Z

Install phase prints this, but exits with code 0. Is this OK?

create-icons.pl
Can't locate Graphics/Magick.pm in @INC (you may need to install the Graphics::Magick module) (@INC contains: /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/site_perl/5.24.2/x86_64-linux-thread-multi /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/site_perl/5.24.2 /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/site_perl /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/site_perl/5.24.2/x86_64-linux-thread-multi /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/site_perl/5.24.2 /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/5.24.2/x86_64-linux-thread-multi /nix/store/yj4b630bm6yscdw8j2sa1sb61j3rdqsy-perl-5.24.2/lib/perl5/5.24.2 .) at create-icons.pl line 23.
BEGIN failed--compilation aborted at create-icons.pl line 23.
make[1]: *** [Makefile:156: www/routino/icons/ball-0.png] Error 2

dotlambda · 2017-09-28T16:29:07Z

I don't see the error with the icon anymore. Can you please check if that's the case on your side as well?
I think the icon is only necessary for the web interface, which cannot be used anyways.

orivej · 2017-09-28T17:41:48Z

I don't see this error too.

I had to change installFlags into makeFlags, otherwise it compiled the sources with -DROUTINO_DATADIR=\"/usr/local/share/routino\". I'm going to merge this if you don't mind.

dotlambda · 2017-09-28T19:17:54Z

Okay, thats fine with me :)

vyp reviewed Sep 24, 2017

View reviewed changes

orivej reviewed Sep 28, 2017

View reviewed changes

dotlambda force-pushed the routino branch from dc0438c to b73201f Compare September 28, 2017 16:23

routino: init at 3.2

f79fde1

dotlambda force-pushed the routino branch from b73201f to f79fde1 Compare September 28, 2017 16:25

routino: fix data path

0395a0d

orivej merged commit ebe52a7 into NixOS:master Sep 28, 2017

dotlambda deleted the routino branch January 17, 2024 05:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

routino: init at 3.2 #29755

routino: init at 3.2 #29755

dotlambda commented Sep 24, 2017

vyp Sep 24, 2017 •

edited

orivej Sep 28, 2017

dotlambda commented Sep 25, 2017 •

edited

vyp commented Sep 25, 2017

dotlambda commented Sep 25, 2017

dotlambda commented Sep 25, 2017

dotlambda commented Sep 28, 2017

vyp commented Sep 28, 2017

orivej Sep 28, 2017

dotlambda Sep 28, 2017

orivej Sep 28, 2017

dotlambda Sep 28, 2017

dotlambda Sep 28, 2017

orivej Sep 28, 2017

dotlambda Sep 28, 2017

orivej Sep 28, 2017

orivej commented Sep 28, 2017 •

edited

dotlambda commented Sep 28, 2017

orivej commented Sep 28, 2017 •

edited

dotlambda commented Sep 28, 2017

routino: init at 3.2 #29755

routino: init at 3.2 #29755

Conversation

dotlambda commented Sep 24, 2017

Motivation for this change

Things done

vyp Sep 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Sep 25, 2017 • edited

vyp commented Sep 25, 2017

dotlambda commented Sep 25, 2017

dotlambda commented Sep 25, 2017

dotlambda commented Sep 28, 2017

vyp commented Sep 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orivej commented Sep 28, 2017 • edited

dotlambda commented Sep 28, 2017

orivej commented Sep 28, 2017 • edited

dotlambda commented Sep 28, 2017

vyp Sep 24, 2017 •

edited

dotlambda commented Sep 25, 2017 •

edited

orivej commented Sep 28, 2017 •

edited

orivej commented Sep 28, 2017 •

edited