Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purePackages.gen: Don't build on Hydra #29763

Merged
merged 1 commit into from Sep 26, 2017
Merged

purePackages.gen: Don't build on Hydra #29763

merged 1 commit into from Sep 26, 2017

Conversation

asppsa
Copy link
Contributor

@asppsa asppsa commented Sep 25, 2017

Until agraef/pure-lang#8 is resolved, this
package can't be compiled. This patch turns off Hydra builds of this
package as part of #28643 (zero Hydra failures)

Motivation for this change

See #28643.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -19,7 +19,7 @@ stdenv.mkDerivation rec {
description = "Pure interface generator";
homepage = http://puredocs.bitbucket.org/pure-gen.html;
license = stdenv.lib.licenses.free;
platforms = stdenv.lib.platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hydraPlatforms = [ ] might be better for this.

Until agraef/pure-lang#8 is resolved, this
package can't be compiled.  This patch turns off Hydra builds of this
package as part of #28643 (zero Hydra failures)
@asppsa
Copy link
Contributor Author

asppsa commented Sep 26, 2017

@joachifm, have changed the commit as per your suggestion.

@joachifm joachifm merged commit 8ac4682 into NixOS:master Sep 26, 2017
globin pushed a commit that referenced this pull request Sep 28, 2017
Until agraef/pure-lang#8 is resolved, this
package can't be compiled.  This patch turns off Hydra builds of this
package as part of #28643 (zero Hydra failures)

(cherry picked from commit 8ac4682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants