Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luxio: init at 13 #29742

Merged
merged 3 commits into from Sep 24, 2017
Merged

luxio: init at 13 #29742

merged 3 commits into from Sep 24, 2017

Conversation

richardipsum
Copy link
Contributor

Motivation for this change

Hi!

I would like to package a git network auth package known as Gitano
Luxio is a dependency of Gitano's, it is a set of lua bindings to POSIX functionality.

I'll be opening separate PRs for each Gitano dependency, since that should make it easier to review.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [] NixOS
    • macOS
    • Linux

I have tested all Gitano dependencies by building and testing Gitano itself using Nix on GNU/Linux.
I'm also happy to maintain Gitano and all its dependencies for the foreseeable future.

Thanks!
Richard

@mention-bot
Copy link

@richardipsum, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @Wyvie and @k0ral to be potential reviewers.

meta = {
platforms = stdenv.lib.platforms.unix;
license = stdenv.lib.licenses.mit;
description = "Lightweight UNIX I/O and POSIX binding for Lua";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick response! And also for fixing this up. I'll try and test subsequent PRs more thoroughly.

But yes I'm happy to be the maintainer for this and all related packages. 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then please add yourself to lib/maintainers.nix as well as to meta.maintainers field of this package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Mic92 Mic92 merged commit 96d3ff6 into NixOS:master Sep 24, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2017

Thanks!

@richardipsum richardipsum deleted the init-luxio branch September 24, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants