hydra-eval-faliures: Print Dependency failures as well as direct failures and update to Python3 #29760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon3 some package fail due to non-exposed dependencies and would thus not appear in the list, for example gcj
|
@berdario, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @globin and @butterflya to be potential reviewers. |
FRidh
reviewed
Sep 26, 2017
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env nix-shell | |||
| #!nix-shell -i python -p pythonFull pythonPackages.requests pythonPackages.pyquery pythonPackages.click | |||
| #!nix-shell -i python3 -p python3Full python3Packages.requests python3Packages.pyquery python3Packages.click | |||
There was a problem hiding this comment.
python3.withPackages(ps: with ps; [ requests pyquery click ])
There was a problem hiding this comment.
???
The closest I've been able to get to what you suggest is
nix-shell -E 'with import <nixpkgs> {}; [(python3.withPackages(ps: with ps; [ requests pyquery click ])) python3Full]'
but that fails with "a single derivation is required"
it seems that it should be possible to do
nix-shell -p 'python35.withPackages(ps: with ps; [ numpy toolz ])'
but the documentation is wrong, since I get this error:
undefined variable ‘python35’ at (string):1:1
(same with python36)
|
This needs to be rebased. There shouldn't be any merge commit. |
|
Other than that it looks good to me. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
some packages fail due to non-exposed dependencies and would thus not appear in the list, for example gcj
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)