Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rhino not depend on GCJ anymore #29759

Merged
merged 1 commit into from Sep 26, 2017
Merged

Make Rhino not depend on GCJ anymore #29759

merged 1 commit into from Sep 26, 2017

Conversation

berdario
Copy link
Contributor

Motivation for this change

This allows it to build and work on Darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@berdario, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @civodul and @nckx to be potential reviewers.

@Mic92 Mic92 merged commit 472bb96 into NixOS:master Sep 26, 2017
globin pushed a commit that referenced this pull request Sep 26, 2017
@berdario @globin
rhino: remove dependency on GCJ (#29759)
17c4f37 
(cherry picked from commit 472bb96)
@berdario berdario mentioned this pull request Sep 26, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berdario @mention-bot @Mic92