Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xwinwrap: init at 4 #29761

Merged
merged 1 commit into from Sep 27, 2017
Merged

xwinwrap: init at 4 #29761

merged 1 commit into from Sep 27, 2017

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Sep 25, 2017

Motivation for this change

Animated wallpapers, example usage (this runs a video as a wallpaper on repeat):

xwinwrap -ov -fs -ni -- mpv --loop=inf -wid WID --panscan=1 <path to video file>
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

'';
homepage = https://shantanugoel.com/2008/09/03/shantz-xwinwrap/;
maintainers = with maintainers; [ infinisil ];
platforms = platforms.linux;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no license associated with this program

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from http://bazaar.launchpad.net/~shantanu-goel/xwinwrap/devel/view/head:/xwinwrap.c, it seems to be free software under the HPND license. There doesn't seem to be an entry for this in lib/licenses.nix though, so an entry should probably be added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the spdx page for adding an entry for it: https://spdx.org/licenses/HPND.html


installPhase = ''
mkdir -p $out/bin
mv {x86_64,i386}/xwinwrap $out/bin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about architectures, but I assume i386 is about the same as i686.

'';
homepage = https://shantanugoel.com/2008/09/03/shantz-xwinwrap/;
maintainers = with maintainers; [ infinisil ];
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from http://bazaar.launchpad.net/~shantanu-goel/xwinwrap/devel/view/head:/xwinwrap.c, it seems to be free software under the HPND license. There doesn't seem to be an entry for this in lib/licenses.nix though, so an entry should probably be added.

'';

meta = with stdenv.lib; {
description = "Shantz XWinWrap utility allows you to use an animated X window as the wallpaper";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should not start with the package name.

@infinisil
Copy link
Member Author

Added the license and fixed the description

@fpletz fpletz merged commit 46b0bca into NixOS:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants