New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xwinwrap: init at 4 #29761
xwinwrap: init at 4 #29761
Conversation
pkgs/tools/X11/xwinwrap/default.nix
Outdated
''; | ||
homepage = https://shantanugoel.com/2008/09/03/shantz-xwinwrap/; | ||
maintainers = with maintainers; [ infinisil ]; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be no license associated with this program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from http://bazaar.launchpad.net/~shantanu-goel/xwinwrap/devel/view/head:/xwinwrap.c, it seems to be free software under the HPND license. There doesn't seem to be an entry for this in lib/licenses.nix though, so an entry should probably be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the spdx page for adding an entry for it: https://spdx.org/licenses/HPND.html
pkgs/tools/X11/xwinwrap/default.nix
Outdated
|
||
installPhase = '' | ||
mkdir -p $out/bin | ||
mv {x86_64,i386}/xwinwrap $out/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about architectures, but I assume i386 is about the same as i686.
pkgs/tools/X11/xwinwrap/default.nix
Outdated
''; | ||
homepage = https://shantanugoel.com/2008/09/03/shantz-xwinwrap/; | ||
maintainers = with maintainers; [ infinisil ]; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from http://bazaar.launchpad.net/~shantanu-goel/xwinwrap/devel/view/head:/xwinwrap.c, it seems to be free software under the HPND license. There doesn't seem to be an entry for this in lib/licenses.nix though, so an entry should probably be added.
pkgs/tools/X11/xwinwrap/default.nix
Outdated
''; | ||
|
||
meta = with stdenv.lib; { | ||
description = "Shantz XWinWrap utility allows you to use an animated X window as the wallpaper"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should not start with the package name.
Added the license and fixed the description |
Motivation for this change
Animated wallpapers, example usage (this runs a video as a wallpaper on repeat):
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)