Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example of hexadecimal sequence #5032

Merged
merged 1 commit into from Sep 26, 2017
Merged

Fix example of hexadecimal sequence #5032

merged 1 commit into from Sep 26, 2017

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Sep 24, 2017

Fix example of hexadecimal sequence

Fixes #5030

Fix hexadecimal sequence
@oprypin
Copy link
Member

oprypin commented Sep 24, 2017

Please use the opposite ordering of lines in the commit message. Ideal example:

Fix example of hexadecimal sequence

Fixes #5030

The exact same goes for pull request title vs content. They should be swapped. Fix #5030 is not even clickable in the title, and you must open it to have any idea of what's going on.

@faustinoaq
Copy link
Contributor Author

@oprypin Ok, Thanks for the advice, Should I open a new PR ?

@faustinoaq faustinoaq changed the title Fix #5030 Fix example of hexadecimal sequence Sep 24, 2017
@oprypin
Copy link
Member

oprypin commented Sep 24, 2017

There's never a need to make a new PR. git commit --amend; git push -f can fix it.
But maybe you don't have to do anything because the person who clicks merge can edit the message, IIRC.

@faustinoaq
Copy link
Contributor Author

But maybe you don't have to do anything because the person who clicks merge can edit the message

So, is this ready to merge?

@RX14 RX14 added this to the Next milestone Sep 26, 2017
@RX14 RX14 merged commit 2eca01b into crystal-lang:master Sep 26, 2017
@faustinoaq faustinoaq deleted the patch-1 branch September 26, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants