Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcj: use from gcc6 #29758

Merged
merged 1 commit into from Sep 25, 2017
Merged

gcj: use from gcc6 #29758

merged 1 commit into from Sep 25, 2017

Conversation

berdario
Copy link
Contributor

Motivation for this change

GCC 4.9 (and subsequently GCJ) fails to build on Darwin. I tried to upgrade this to get reverse dependencies to succeed (but it turned out not to be that simple).

Anyhow, this allows GCJ to build on Darwin, but before merging, I'd wait to see the outcome of the CI when building pdftk on Linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz added this to the 17.09 milestone Sep 25, 2017
@fpletz fpletz merged commit cd501e3 into NixOS:master Sep 25, 2017
@fpletz
Copy link
Member

fpletz commented Sep 25, 2017

Thanks!

@berdario
Copy link
Contributor Author

@fpletz uhm, Linux failed to build GCJ, though :/

@vcunat
Copy link
Member

vcunat commented Sep 25, 2017 •
edited

libgcj.so is in $lib and it's getting several references to $out within string messages. BTW, Hydra won't finish it even on Darwin, though it's due to log length :-) https://hydra.nixos.org/build/61797980

@vcunat
Copy link
Member

vcunat commented Sep 25, 2017

Aand, upstream gcc7 completely removed support for Java, so whatever solution we produce, it won't last too long...

@7c6f434c
Copy link
Member

7c6f434c commented Sep 25, 2017 •
edited

Well, if we still have some remainders of GCC4, that means a GCC6 solution could survive a few years…

Maybe by that time there will be a real replacement for pdftk. Because right now I don't know any.

@vcunat
Copy link
Member

vcunat commented Sep 25, 2017

Yes, and gcc5 can also survive years, especially if we need it for something. I don't follow Java, but I suppose free unix* has been moving towards openjdk and related compilers...

@7c6f434c
Copy link
Member

Most of the Java-based stuff uses OpenJDK, that's for sure — pdftk is just a rare case that was GCJ-only all its life, with no support for any kind of usual JDK.

@berdario
Copy link
Contributor Author

Yeah, this is not the most useful pull request, but if we could get GCJ building with GCC6 it could survive a bit longer.

I also wrote down a couple of notes about pdftk here: #29715

@vcunat vcunat mentioned this pull request Sep 28, 2017
Closed
@vcunat
Copy link
Member

vcunat commented Oct 1, 2017

Well, on Hydra we won't have yet binaries for gcj on darwin, as the jobs get killed after producing 64 MB of log output.

@schmittlauch
Copy link
Member

@7c6f434c FYI regarding a replacement for pdftk, I found https://github.com/hellerbarde/stapler and might package it after testing it for a while.

@7c6f434c
Copy link
Member

7c6f434c commented Feb 1, 2019

@schmittlauch thanks, ineteresting — I can only hope background and stamp will work at some point…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@berdario @fpletz @vcunat @7c6f434c @schmittlauch